[PATCH] D49758: [clangd] allow clients to pass in compilationDatabaseChanges in the 'workspace/didChangeConfiguration' request

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

The mode of operation where compile commands come from the client seems useful, but I wonder if there's any value in mixing it with `compile_commands.json` and other CDB plugins.
Do you plan to use the overridden commands in conjunction with CDB plugins or do you want the client to exclusively control the compile commands?



================
Comment at: clangd/Protocol.h:429
+  // The changes that happened to the compilation database.
+  llvm::Optional<std::map<std::string, std::vector<std::string>>>
+      compilationDatabaseChanges;
----------------
- Maybe add a comment that the key of the map is a file name?
- The value does not contain the working directory at the time, but we need that for building `tooling::CompileCommand`, maybe add it?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D49758