[PATCH] D49773: Add new file test/support/test_comparisons.h

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 24 20:48:19 PDT 2018


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

Otherwise, I'm quite happy with this patch.

The only downside I see is if `testComparisons6` fails, it will report the source of the failure as being in the header, and not provide information about the callee.
But I think having simpler tests to read and write is more important. Hopefully they shouldn't be falling too often anyway :-P


https://reviews.llvm.org/D49773





More information about the cfe-commits mailing list