[PATCH] D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe.

[Akira Hatanaka via Phabricator via cfe-commits]

ahatanak added inline comments.


================
Comment at: lib/CodeGen/CGBlocks.cpp:1905
+    case BlockCaptureEntityKind::None:
+      llvm_unreachable("unexpected BlockCaptureEntityKind");
     }
----------------
rjmccall wrote:
> These two switches differ only in (1) what kind of cleanup they push and (2) a small optimization that can easily be conditionalized by the request to push an EH-only cleanup.
Merged the two switch statements into helper function pushCaptureCleanup.


Repository:
  rC Clang

https://reviews.llvm.org/D49718