[PATCH] D49732: [AST][2/4] Move the bit-fields from FunctionDecl and CXXConstructorDecl into DeclContext

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

Anotherone in need of clang-format, otherwise seems alright to me.



================
Comment at: include/clang/AST/Decl.h:1809
+  // and setMultiVersion do not simply set/read the corresponding bit.
+  void setPureImpl(bool isPure) { FunctionDeclBits.IsPure = isPure; }
+  bool isDeletedImpl() const { return FunctionDeclBits.IsDeleted; }
----------------
I'm not sure I see the value of these.  FunctiondeclBits is littered around here a bit, so I don't think these additional ones have all that much value.  At least the MultiVersion case actually doesn't do anything but call these.


================
Comment at: include/clang/AST/Decl.h:2033
+  }
+  void setHasImplicitReturnZero(bool IRZ) {
+    FunctionDeclBits.HasImplicitReturnZero = IRZ;
----------------
Newline.


Repository:
  rC Clang

https://reviews.llvm.org/D49732