[PATCH] D49652: Apply -fdebug-prefix-map in reverse of command line order

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 24 08:14:04 PDT 2018


probinson added a comment.

In https://reviews.llvm.org/D49652#1172498, @alxu wrote:

> my general theory is that it's better to have tests that test everything at once if possible, but I guess it's unlikely enough that the debug info path will be correct in the IR and then not correct in the generated file and that that won't be caught by LLVM tests.


The in-tree lit tests are very focused unit tests.  The principle here is that a more focused test will be easier to diagnose when it fails.  The LLVM project on its own really does not have much end-to-end testing and hardly any of that looks at debug info.  Instead we have a bunch of vendors all running their own test suites.  It's very much a tradeoff, and I personally view the in-tree lit tests as barely more than basic smoke tests.  But it's how the project works, and so new in-tree tests need to be consistent with that approach.


Repository:
  rC Clang

https://reviews.llvm.org/D49652





More information about the cfe-commits mailing list