[PATCH] D49375: [NEON] Define half-precision vmaxnm intrinsics only when available

Ivan Kosarev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 23 06:31:49 PDT 2018


kosarev added a comment.

Thanks for reviewing!



================
Comment at: include/clang/Basic/arm_neon.td:1466
   def VMINH         : SInst<"vmin", "ddd", "hQh">;
-  def FMAXNMH       : SInst<"vmaxnm", "ddd", "hQh">;
-  def FMINNMH       : SInst<"vminnm", "ddd", "hQh">;
+  let ArchGuard = "__ARM_ARCH >= 8 && defined(__ARM_FEATURE_NUMERIC_MAXMIN) && defined(__ARM_FEATURE_FP16_VECTOR_ARITHMETIC)" in {
+    def FMAXNMH       : SInst<"vmaxnm", "ddd", "hQh">;
----------------
SjoerdMeijer wrote:
> nit: indentation?
Do we want some special indentation here?


https://reviews.llvm.org/D49375





More information about the cfe-commits mailing list