[PATCH] D49546: [clangd] Implement query iterators for Dex symbol index

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 23 01:33:21 PDT 2018


kbobyrev updated this revision to Diff 156725.
kbobyrev added a comment.
Herald added a subscriber: mgrang.

- Implemented convenient dumping via `llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, QueryIterator &Iterator)`, which dumps iterator tree in human-readable format, e.g. `(&& [1, 2, 3] (|| [3, 4, 5] []))`
- Implemented rather straightforward iterator `cost` for more efficient `AndIterator` iterations

The functional part is probably done at this point, the only thing to do at this point is to properly document written code leaving only few `FIXME`s for the future.


https://reviews.llvm.org/D49546

Files:
  clang-tools-extra/clangd/CMakeLists.txt
  clang-tools-extra/clangd/index/dex/QueryIterator.cpp
  clang-tools-extra/clangd/index/dex/QueryIterator.h
  clang-tools-extra/unittests/clangd/CMakeLists.txt
  clang-tools-extra/unittests/clangd/DexIndexTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49546.156725.patch
Type: text/x-patch
Size: 33361 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180723/768129fa/attachment-0001.bin>


More information about the cfe-commits mailing list