[PATCH] D49568: [analyzer][WIP] Scan the program state map in the visitor only once in DanglingInternalBufferChecker

Reka Kovacs via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 19 14:45:10 PDT 2018


rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, szepet, baloghadamsoftware, whisperity.

In order to avoid scanning the map at each node in the bug reporter visitor, the `MemRegion` representing the container object associated with the tracked pointer symbol is looked up once in the visitor constructor. However, at the point where the visitor is constructed, we no longer find the appropriate `MemRegion` entry in the map, as it has already been cleaned up.
In this patch, I removed some clean-ups to allow for the look-up, but I suspect this is not the right approach.


Repository:
  rC Clang

https://reviews.llvm.org/D49568

Files:
  lib/StaticAnalyzer/Checkers/AllocationState.h
  lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp
  lib/StaticAnalyzer/Checkers/MallocChecker.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49568.156357.patch
Type: text/x-patch
Size: 4700 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180719/1ce0d8ff/attachment.bin>


More information about the cfe-commits mailing list