[PATCH] D49457: DR330: when determining whether a cast casts away constness, consider qualifiers from all levels matching a multidimensional array

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 17 18:50:23 PDT 2018


rjmccall added inline comments.


================
Comment at: lib/Sema/SemaCast.cpp:535
+    T1 = Unwrap(T1);
+    T2 = Unwrap(T2).withCVRQualifiers(T2.getCVRQualifiers());
+  }
----------------
Hmm.  Just CVR?  I understand that we can have problems here with the enumerated qualifiers, so maybe we shouldn't blindly merge them, but is there some way to propagate them if not conflicting?


Repository:
  rC Clang

https://reviews.llvm.org/D49457





More information about the cfe-commits mailing list