[PATCH] D49265: [Tooling] Add operator== to CompileCommand

Simon Marchi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 16 11:50:40 PDT 2018


simark added a comment.

In https://reviews.llvm.org/D49265#1163740, @dblaikie wrote:

> Any chance this can/should be unit tested? (also, in general (though might
>  not matter in this instance), symmetric operators like == should be
>  implemented as non-members (though they can still be friends and if they
>  are, can be defined inline in the class definition as a member could be),
>  so any implicit conversions apply equally to the LHS as the RHS of the
>  expression)


Of course, I'm on it.


Repository:
  rC Clang

https://reviews.llvm.org/D49265





More information about the cfe-commits mailing list