[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added inline comments.


================
Comment at: include/charconv:372
+
+    auto __len = __last - __p;
+    if (__value != 0 || !__len)
----------------
Are you missing an edge case here? What happens if `__last == __first && __value == 0`?



================
Comment at: test/support/charconv_test_helpers.h:40
+constexpr bool
+_fits_in(T, true_type /* non-narrowing*/, ...)
+{
----------------
We don't need to use ugly names here in the test suite.



Repository:
  rCXX libc++

https://reviews.llvm.org/D41458