[PATCH] D48845: [Sema] Add fixit for unused lambda captures

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 13 12:20:57 PDT 2018


aaron.ballman added inline comments.


================
Comment at: include/clang/Sema/DeclSpec.h:2552-2553
     ParsedType InitCaptureType;
+    SourceLocation LocStart;
+    SourceLocation LocEnd;
+
----------------
aaron.ballman wrote:
> How does `LocStart` relate to the existing source location `Loc`? I think this should have a more descriptive name of what location is involved.
Now that I think about this more, I wonder if this is better expressed as `SourceRange CaptureRange;` given that there's always a start and end and they should never be equal?


Repository:
  rC Clang

https://reviews.llvm.org/D48845





More information about the cfe-commits mailing list