[PATCH] D49224: [clangd] log request/response messages with method/ID/error at INFO level

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 12 04:29:04 PDT 2018


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clangd/JSONRPCDispatcher.cpp:138
   });
+  auto ID = 1;
+  log("--> {0}({1})", Method, ID);
----------------
nit I'd suggest putting this statement immediately after the above `FIXME`, it took me a while to understand why it is `1`.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D49224





More information about the cfe-commits mailing list