[PATCH] D48821: [clangd] ClangdServer::codeComplete return CodeCompleteResult, not LSP struct.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 2 01:53:30 PDT 2018


sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.

This provides more structured information that embedders can use for rendering.
ClangdLSPServer continues to call render(), so NFC.

The patch is:

- trivial changes to ClangdServer/ClangdLSPServer
- mostly-mechanical updates to CodeCompleteTests etc for the new API
- new direct tests of render() in CodeCompleteTests
- tiny cleanups to CodeCompletionItem (operator<< and missing initializers)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D48821

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  clangd/CodeComplete.cpp
  clangd/CodeComplete.h
  unittests/clangd/ClangdTests.cpp
  unittests/clangd/CodeCompleteTests.cpp
  unittests/clangd/SyncAPI.cpp
  unittests/clangd/SyncAPI.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48821.153679.patch
Type: text/x-patch
Size: 35613 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180702/3b354e71/attachment-0001.bin>


More information about the cfe-commits mailing list