[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 29 21:29:53 PDT 2018


mclow.lists added a comment.

I want to point out that this code (not -necessarily- this patch, but where it lives) needs to be rewritten.

There is no prohibition on users specializing `allocator_traits` for their allocators, and yet libc++'s vector depends on the existence of `allocator_traits<Allocator>::__construct_range_forward` (among other things).


https://reviews.llvm.org/D48342





More information about the cfe-commits mailing list