[PATCH] D48727: [Fixed Point Arithmetic] Rename `-fsame-fbits` flag

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 28 09:32:25 PDT 2018


rjmccall added a comment.

This all looks reasonable except that I think the interpretation is exactly backwards, no?  From the documentation on the option, `-fpadding-on-unsigned-fixed-point` causes there to be padding, i.e. the inverse of the old `SameFBits`; but the default value, comments, and boolean checks throughout the code are all still using the old interpretation.


Repository:
  rC Clang

https://reviews.llvm.org/D48727





More information about the cfe-commits mailing list