[PATCH] D48681: [CFG] [analyzer] Add construction contexts for function arguments.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 27 16:29:24 PDT 2018


NoQ added inline comments.


================
Comment at: lib/Analysis/CFG.cpp:5011
     print_initializer(OS, Helper, SICC->getCXXCtorInitializer());
-    break;
+    return;
   }
----------------
For consistency.


================
Comment at: lib/Analysis/CFG.cpp:5074-5078
   for (auto I: Stmts)
     if (I) {
       OS << ", ";
       Helper.handledStmt(const_cast<Stmt *>(I), OS);
     }
----------------
I'm starting to regret this code reuse mechanism. I guess i should have made a simple lambda instead to wrap all `handledStmt` calls.


Repository:
  rC Clang

https://reviews.llvm.org/D48681





More information about the cfe-commits mailing list