[PATCH] D48211: [clangd] Do not show namespace comments.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 27 02:51:41 PDT 2018


ilya-biryukov added inline comments.


================
Comment at: clangd/CodeCompletionStrings.cpp:172
   // get this declaration, so we don't show documentation in that case.
   if (Result.Kind != CodeCompletionResult::RK_Declaration)
     return "";
----------------
sammccall wrote:
> while here, should this be if (Result.Declaration)? I make this mistake a lot...
Looking at the FIXME above, it seems we might show a different comment from the one returned by clang's code completion.
I'll double-check if we do the right thing there and will try to do `if (!Result.Declaration)` in a follow-up patch.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D48211





More information about the cfe-commits mailing list