[PATCH] D48549: Use Triple::isMIPS() instead of enumerating all Triples. NFC

Simon Atanasyan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 25 07:25:05 PDT 2018


atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM. the only minor nit



================
Comment at: lib/Driver/ToolChains/FreeBSD.cpp:321
   // back to '/usr/lib' if it doesn't exist.
-  if ((Triple.getArch() == llvm::Triple::x86 ||
-       Triple.getArch() == llvm::Triple::mips ||
-       Triple.getArch() == llvm::Triple::mipsel ||
-       Triple.getArch() == llvm::Triple::ppc) &&
+  if ((Triple.getArch() == llvm::Triple::x86 || Triple.isMIPS32() || Triple.getArch() == llvm::Triple::ppc) &&
       D.getVFS().exists(getDriver().SysRoot + "/usr/lib32/crt1.o"))
----------------
Too long line.


Repository:
  rC Clang

https://reviews.llvm.org/D48549





More information about the cfe-commits mailing list