[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

Momchil Velikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 25 02:14:13 PDT 2018


chill added a comment.

In https://reviews.llvm.org/D46013#1140336, @t.p.northover wrote:

> I'm fine with the ABI changes, but I'm not very convinced by the "NaturalAlignment" name.


I'd rather not put target names in API functions. The meaning of that field is pretty target
independent ("alignment of type, before alignment adjustments")
If we use it only in ARM/AArch64 we can put a comment in that sense and
maybe rename it to `UnadjustedAlignement` or something else more descriptive than `NaturalAlignement` ?


https://reviews.llvm.org/D46013





More information about the cfe-commits mailing list