[PATCH] D47532: [ASTImporter] Import the whole redecl chain of functions

[Aleksei Sidorin via Phabricator via cfe-commits]

a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.

Hi Gabor,

The patch LG, thank you for addressing my questions. Just some stylish nits.



================
Comment at: unittests/AST/ASTImporterTest.cpp:2021
+
+TEST_P(ImportFriendFunctions,
+       DISABLED_ImportFriendFunctionRedeclChainDefWithClass_ImportTheProto) {
----------------
Could you add comments why these tests are disabled?


================
Comment at: unittests/AST/ASTImporterTest.cpp:2217
+
+  //Check that the function template instantiation is NOT the child of the TU
+  auto Pattern = translationUnitDecl(
----------------
Please add a space after '//' and a dot in the end. Same below.


================
Comment at: unittests/AST/ASTImporterTest.cpp:2328
+      Lang_CXX11, "input0.cc");
+  auto *FromD = FirstDeclMatcher<FunctionDecl>().match(
+      FromTU, functionDecl(hasName("foo")));
----------------
In this patch, sometimes '*' is used for auto, sometimes not. Could we make it consistent?


Repository:
  rC Clang

https://reviews.llvm.org/D47532