[PATCH] D47534: [ASTImporter] Add new tests about templated-described swing

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 24 14:08:17 PDT 2018


a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.

Hi Gabor,

Tests are always welcome. This patch is OK and can be committed after fixing nits without additional approval.



================
Comment at: unittests/AST/ASTImporterTest.cpp:1097
+      struct X;
+       template <typename T0>
+      struct X<T0*> {};
----------------
Broken indentation.


================
Comment at: unittests/AST/ASTImporterTest.cpp:1098
+       template <typename T0>
+      struct X<T0*> {};
+    };
----------------
T0 * (missed space)


Repository:
  rC Clang

https://reviews.llvm.org/D47534





More information about the cfe-commits mailing list