[PATCH] D48522: [analyzer] Highlight c_str() call in DanglingInternalBuffer checker

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 24 10:08:43 PDT 2018


xazax.hun accepted this revision.
xazax.hun added inline comments.


================
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:41
+    // Tracked pointer to a buffer.
+    SymbolRef Sym;
+
----------------
I am fine with this as is, but I prefer self documenting code in general. Naming this variable PtrToBuf or something like that would conway the same information and render the comment redundant. 


https://reviews.llvm.org/D48522





More information about the cfe-commits mailing list