[PATCH] D46485: Add python tool to dump and construct header maps

Stella Stamenova via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 20 18:30:21 PDT 2018


Yes, I can try it out. Feel free to add me to the review as well.

________________________________
From: Bruno Cardoso Lopes <bruno.cardoso at gmail.com>
Sent: Wednesday, June 20, 2018 6:25 PM
To: Stella Stamenova
Cc: Richard Smith; Duncan Exon Smith; jkorous at apple.com; Michał Górny; cfe-commits
Subject: Re: [PATCH] D46485: Add python tool to dump and construct header maps

On Wed, Jun 20, 2018 at 5:42 PM Stella Stamenova <stilis at microsoft.com> wrote:
>
> Thanks Bruno,
>
> I ran a build as well and I can see that hmaptool is now in the correct bin directory. The tests still failed though because on Windows, at least, you need to explicitly call python to run a script e.g. "python hmaptool".
>
> There are a few tests in LLVM that do that, for example:
>
> ; RUN: %python -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
>
> I am not sure whether you can simply call python on hmaptool or if you would have to include the fullpath to it though.

Oh, I see. I'll revert the commits while I find a solution for this.
Any chance you can give it a try before I re-commit if I send you an
updated patch?

Thanks,

--
Bruno Cardoso Lopes
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.brunocardoso.cc&data=02%7C01%7Cstilis%40microsoft.com%7C9a3d5b51b26c4ff1a8db08d5d715df88%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636651411307060645&sdata=2EamqaQFSd35ZIqp%2Ft9TxAUZYoeDg8NkD47VaERkoG8%3D&reserved=0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180621/6be8764b/attachment.html>


More information about the cfe-commits mailing list