[PATCH] D46485: Add python tool to dump and construct header maps

[Stella Stamenova via cfe-commits]

Thanks Bruno,

I ran a build as well and I can see that hmaptool is now in the correct bin directory. The tests still failed though because on Windows, at least, you need to explicitly call python to run a script e.g. "python hmaptool".

There are a few tests in LLVM that do that, for example:

; RUN: %python -c "print(' ' * 65536)" > %t.cache/llvmcache-foo

I am not sure whether you can simply call python on hmaptool or if you would have to include the fullpath to it though.

Thanks,
-Stella

-----Original Message-----
From: Bruno Cardoso Lopes <bruno.cardoso at gmail.com> 
Sent: Wednesday, June 20, 2018 4:14 PM
To: Stella Stamenova <stilis at microsoft.com>
Cc: Richard Smith <richard at metafoo.co.uk>; Duncan Exon Smith <dexonsmith at apple.com>; jkorous at apple.com; mgorny at gentoo.org; cfe-commits <cfe-commits at lists.llvm.org>
Subject: Re: [PATCH] D46485: Add python tool to dump and construct header maps

Attempted a fix in r335190, watching the bots.
On Wed, Jun 20, 2018 at 3:53 PM Bruno Cardoso Lopes <bruno.cardoso at gmail.com> wrote:
>
> Hi Stella,
>
> On Wed, Jun 20, 2018 at 3:44 PM Stella Stamenova via Phabricator 
> <reviews at reviews.llvm.org> wrote:
> >
> > stella.stamenova added a comment.
> >
> > This breaks the clang tests on Windows when building using Visual Studio as none of the updated tests can find hmaptool.
>
> Yes. I contacted Galina about that but maybe it was the wrong person 
> to contact.
>
> > Visual Studio as a generator supports multiple configurations, so its bin folder varies depending on the build configuration. The generalized version of the bin directory is: ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin. This is actually the proper bin directory to use for any generator because ${CMAKE_CFG_INTDIR} is simply '.' when the generator (such as ninja) doesn't support multiple configurations.
>
> Good to know.
>
> > I can look into a fix and submit a change for review tomorrow if you can't, but in the future please make sure to use the full path to the bin directory (${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) to avoid missing a generator.
>
> I'll try to fix it now. Thanks for the heads up!
>
> >
> >
> > Repository:
> >   rC Clang
> >
> > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frev
> > iews.llvm.org%2FD46485&data=02%7C01%7CSTILIS%40microsoft.com%7C83fc2
> > 84426aa4e51e2d908d5d70387cc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7
> > C1%7C636651332530245571&sdata=yGlv3J3wsuEvQGDd3b7Kq8FU3dMqORS4eH8a%2
> > BL3ikzk%3D&reserved=0
> >
> >
> >
>
>
> --
> Bruno Cardoso Lopes
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.br
> unocardoso.cc&data=02%7C01%7CSTILIS%40microsoft.com%7C83fc284426aa4e51
> e2d908d5d70387cc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C63665133
> 2530245571&sdata=KwMaPuOYjHXndEiYOBVZY29vefhR3poMegBV4HCPaxk%3D&reserv
> ed=0



--
Bruno Cardoso Lopes
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.brunocardoso.cc&data=02%7C01%7CSTILIS%40microsoft.com%7C83fc284426aa4e51e2d908d5d70387cc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636651332530245571&sdata=KwMaPuOYjHXndEiYOBVZY29vefhR3poMegBV4HCPaxk%3D&reserved=0