[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

Roger Ferrer Ibanez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 20 03:56:01 PDT 2018


rogfer01 added inline comments.


================
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:381
 
+  // FIXME: currently defaults to the soft-float ABIs. Will need to be
+  // expanded to select ilp32f, ilp32d, lp64f, lp64d when appropriate.
----------------
When 64-bit is upstreamed and `lp64d` implemented, I plan to default `riscv64-unknown-linux-gnu` to `lp64d` here.

Does this sound sensible?


https://reviews.llvm.org/D48357





More information about the cfe-commits mailing list