[PATCH] D48297: [Darwin] Add a warning for missing include path for libstdc++

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 18 14:40:27 PDT 2018


arphaman added inline comments.


================
Comment at: lib/Frontend/InitHeaderSearch.cpp:491
     } else {
-      AddDefaultCPlusPlusIncludePaths(triple, HSOpts);
+      AddDefaultCPlusPlusIncludePaths(Lang, triple, HSOpts);
     }
----------------
bruno wrote:
> If we happen to suggest libc++, but it's also not there, do we still want the warning? Should we check it exists first? 
I don't think such a check is that valuable on Darwin, which is where this warning fires, since libc++ is the default standard library on Darwin.


Repository:
  rC Clang

https://reviews.llvm.org/D48297





More information about the cfe-commits mailing list