[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Xing via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 18 09:13:50 PDT 2018


Higuoxing added a comment.

In https://reviews.llvm.org/D47687#1135284, @dexonsmith wrote:

> Did you miss this comment from my previous review?
>
> > I would like to see tests like the following:
> > 
> >   NESTING_VOID_WRAPPER(&&, ||, i, i, i && i); // no warning.
> >   NESTING_VOID_WRAPPER(||, &&, i, i, i || i); // no warning.


I think this test case should pass, please wait
I cloned a newer version codes, and I am compiling it... about 1-2 hours

Sorry for disturbing you too much on reviewing codes

I think I could give it a try on giving it a fix-it...

Big thanks!


https://reviews.llvm.org/D47687





More information about the cfe-commits mailing list