[PATCH] D47957: [clangd] Add option to fold overloads into a single completion item.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 15 01:30:56 PDT 2018


ilya-biryukov added a comment.

Overall LG. It would be nice to mention somewhere that we since we bundle overloads client-side we might run into weird side-effects (e.g. return less completion items than the specified limit) in case the index returns too many non-bundled.



================
Comment at: clangd/tool/ClangdMain.cpp:62
 
+// TODO: also support "plain" style where signatures are always omitted.
+enum CompletionStyleFlag {
----------------
NIT: maybe use FIXME to be consistent with the rest of clangd?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D47957





More information about the cfe-commits mailing list