[PATCH] D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:9222
+    if (CC != 4)
+      return nullptr;
+    Value *A = Builder.CreateExtractElement(Ops[0], (uint64_t)0);
----------------
What does returning nullptr here do?


================
Comment at: lib/CodeGen/CGBuiltin.cpp:9246
+    if (CC != 4)
+      return nullptr;
+    Function *F = CGM.getIntrinsic(Intrinsic::sqrt, Ops[0]->getType());
----------------
Again  don't know what the caller is going to do with nullptr.


Repository:
  rC Clang

https://reviews.llvm.org/D41168