[clang-tools-extra] r334589 - Revert "[clangd] Log completion context type. NFC"

Sam McCall via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 13 04:31:20 PDT 2018


Author: sammccall
Date: Wed Jun 13 04:31:20 2018
New Revision: 334589

URL: http://llvm.org/viewvc/llvm-project?rev=334589&view=rev
Log:
Revert "[clangd] Log completion context type. NFC"

This reverts commit r334572, which has a potential use-after-free.

Modified:
    clang-tools-extra/trunk/clangd/CodeComplete.cpp

Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/CodeComplete.cpp?rev=334589&r1=334588&r2=334589&view=diff
==============================================================================
--- clang-tools-extra/trunk/clangd/CodeComplete.cpp (original)
+++ clang-tools-extra/trunk/clangd/CodeComplete.cpp Wed Jun 13 04:31:20 2018
@@ -881,12 +881,10 @@ public:
     SPAN_ATTACH(Tracer, "merged_results", NBoth);
     SPAN_ATTACH(Tracer, "returned_results", Output.items.size());
     SPAN_ATTACH(Tracer, "incomplete", Output.isIncomplete);
-    log(llvm::formatv(
-        "Code complete ({0}): {1} results from Sema, {2} from Index, "
-        "{3} matched, {4} returned{5}.",
-        getCompletionKindString(Recorder->CCContext.getKind()), NSema, NIndex,
-        NBoth, Output.items.size(),
-        Output.isIncomplete ? " (incomplete)" : ""));
+    log(llvm::formatv("Code complete: {0} results from Sema, {1} from Index, "
+                      "{2} matched, {3} returned{4}.",
+                      NSema, NIndex, NBoth, Output.items.size(),
+                      Output.isIncomplete ? " (incomplete)" : ""));
     assert(!Opts.Limit || Output.items.size() <= Opts.Limit);
     // We don't assert that isIncomplete means we hit a limit.
     // Indexes may choose to impose their own limits even if we don't have one.




More information about the cfe-commits mailing list