[PATCH] D48040: Implement constexpr __builtin_*_overflow

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: lib/Sema/SemaChecking.cpp:210
+    Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+    TheCall->setArg(I, Arg.get());
   }
----------------
efriedma wrote:
> Can you split this change into a separate patch?  Testcase:
> 
> ```
> int a() {
>   const int x = 3;
>   static int z;
>   constexpr int * y = &z;
>   return []() { return __builtin_sub_overflow(x,x,y); }();
> }```
Can you clarify what you mean?  That above testcase (with added captures) seems to work currently.  What difference in behavior should I be expecting?


https://reviews.llvm.org/D48040