[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

[George Karpenkov via Phabricator via cfe-commits]

george.karpenkov added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+                    new Callback(LCtx, MRMgr, ITraits));
+  Finder.matchAST(ASTCtx);
+
----------------
ormris wrote:
> george.karpenkov wrote:
> > IMO using the iterator directly (e.g. like it was done in https://github.com/llvm-mirror/clang/blob/master/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp#L213) leads to a much cleaner code and saves you from having to define a callback class.
> Hmm... I think that's a better approach. Let me see if I can get that working.
@ormris Yeah I'm really not sure why all examples use the callback API by default.


Repository:
  rC Clang

https://reviews.llvm.org/D47044