[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

George Karpenkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 11 09:48:10 PDT 2018


george.karpenkov added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+                    new Callback(LCtx, MRMgr, ITraits));
+  Finder.matchAST(ASTCtx);
+
----------------
IMO using the iterator directly (e.g. like it was done in https://github.com/llvm-mirror/clang/blob/master/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp#L213) leads to a much cleaner code and saves you from having to define a callback class.


Repository:
  rC Clang

https://reviews.llvm.org/D47044





More information about the cfe-commits mailing list