[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

[Csaba Dabis via Phabricator via cfe-commits]

Charusso added a comment.

@lebedev.ri there is all the false positive results from the last publicated result-dump:

F6334659: curl-lib-curl_path-c.html <https://reviews.llvm.org/F6334659>
second result: F6334660: ffmpeg-libavformat-sdp.c.html <https://reviews.llvm.org/F6334660>
all result: F6334663: openssl-apps-ca-c.html <https://reviews.llvm.org/F6334663>
F6334665: postgresql-src-interfaces-ecpg-preproc-pgc-c.html <https://reviews.llvm.org/F6334665>
F6334667: redis-src-redis-benchmark-c.html <https://reviews.llvm.org/F6334667>

(Note: the two `memchr()` result were false positive in that post and there is no new result with the new matcher.)

Does the new test cases cover your advice?



================
Comment at: docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:105
+
+   An integer non-zero value specifying if the target version implements ``_s``
+   suffixed memory and character handler functions which is safer than older
----------------
whisperity wrote:
> Why is this an integer, rather than a bool?
This is how the other Tidy checkers are use their options, I do not know either.


https://reviews.llvm.org/D45050