[PATCH] D47301: Warning for framework include violation from Headers to PrivateHeaders

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 8 15:25:14 PDT 2018


vsapsai added inline comments.


================
Comment at: lib/Lex/HeaderSearch.cpp:683
+  // from Foo.framework/PrivateHeaders, since this violates public/private
+  // api boundaries and can cause modular dependency cycles.
+  if (!IsIncluderPrivateHeader && IsIncludeeInFramework &&
----------------
Please capitalize "api". The rest looks good.


https://reviews.llvm.org/D47301





More information about the cfe-commits mailing list