[PATCH] D47912: [CMake] Consider LLVM_APPEND_VC_REV when generating SVNVersion.inc

Gabor Buella via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 7 15:38:16 PDT 2018


GBuella added a comment.

In https://reviews.llvm.org/D47912#1125803, @smeenai wrote:

> I believe LLVM_APPEND_VC_REV controls whether the revision is appended to LLVM version string (e.g. the output of `llvm-config --version`), whereas the SVNRevision.inc file (which is what's causing the relink after amending) is used for e.g. the `clang --version` output, so I'm not sure this is the right thing to do. I would also love for an option to disable the SVNRevision stuff entirely though.


Right, that is why I added the word "quickfix".
Perhaps we can add a `CLANG_APPEND_VC_REV` CMake option?


Repository:
  rC Clang

https://reviews.llvm.org/D47912





More information about the cfe-commits mailing list