[PATCH] D47577: [clang-format] Separate block comments with CRLF correctly

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 7 07:24:54 PDT 2018


alexfh added a reviewer: djasper.
alexfh added inline comments.


================
Comment at: lib/Format/BreakableToken.cpp:327
+  TokenText.substr(2, TokenText.size() - 4)
+      .split(Lines, TokenText.count('\r') > 0 ? "\r\n" : "\n");
 
----------------
FYI, there's a global UseCRLF flag in WhitespaceManager. It may make sense to use it everywhere instead of deciding for each comment. But I'll let actual clang-format maintainers decide on pros and cons of this.


Repository:
  rC Clang

https://reviews.llvm.org/D47577





More information about the cfe-commits mailing list