[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

Ethan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 6 13:16:12 PDT 2018


ethanhs added inline comments.


================
Comment at: lib/Headers/immintrin.h:387
+#if defined(__i386__) || defined(__x86_64__)
+static __inline__ long __DEFAULT_FN_ATTRS
+_InterlockedExchange_HLEAcquire(long volatile *_Target, long _Value) {
----------------
craig.topper wrote:
> what is __DEFAULT_FN_ATTRS defined to here? Its not defined in this file and should have been undeffed before leaving any other file. If its still defined here, it's a bug.
When I added the _MSC_VER guard I realized this too. Not sure how this still compiled, as when I grepped [#|#un]def.*__DEFAULT_FN_ATTRS, every define had a matching undef.


Repository:
  rC Clang

https://reviews.llvm.org/D47672





More information about the cfe-commits mailing list