[PATCH] D47821: [clangd] Make workspace/symbols actually rank its results.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 6 08:10:06 PDT 2018


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clangd/FindSymbols.cpp:159
+    else
+      return;
+    Relevance.merge(Sym);
----------------
Should we add a log statement here? IMO, this rarely happens? If it happens, it means that the fuzzy matcher algorithms used by index and clangd side have disagreement.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D47821





More information about the cfe-commits mailing list