[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 6 07:47:00 PDT 2018


aprantl added inline comments.


================
Comment at: lib/CodeGen/CGDecl.cpp:1949
 
+  // Set artificial debug location in order to preserve the scope
+  auto DL = ApplyDebugLocation::CreateArtificial(*this);
----------------
Can you make that comment elaborate more about why this is being done? For example, you could add an "otherwise mem2reg will ..."

Also please note that all comments in LLVM need to be full sentences with a "." at the end :-)


Repository:
  rC Clang

https://reviews.llvm.org/D47097





More information about the cfe-commits mailing list