[PATCH] D47733: [CUDA][HIP] Set kernel calling convention before arrange function

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 5 14:28:20 PDT 2018


tra added a comment.

Looks OK overall, but I'm not very familiar with CGCall, so you may want to dig through the history and find someone with more expertise.



================
Comment at: test/CodeGenCUDA/kernel-args-amdgcn.cu:1
+// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fcuda-is-device -emit-llvm %s -o - | FileCheck %s
+#include "Inputs/cuda.h"
----------------
Please add some checks that verify that CUDA kernels still don't have any extra calling conventions set.


https://reviews.llvm.org/D47733





More information about the cfe-commits mailing list