[PATCH] D47643: Rewrite JSON dispatcher loop using C IO (FILE*) instead of std::istream.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a subscriber: hokein.
ilya-biryukov added a comment.

The change LG, but I'm not a big expert on C APIs, so I might've missed something.  @ioeric, @hokein, maybe you have some experience with those and want to take a look?
PS I've checked it on my Mac and lldb seems to attach just fine.



================
Comment at: clangd/JSONRPCDispatcher.cpp:70
   }
-  log(llvm::Twine("--> ") + S);
+  log(llvm::Twine("--> ") + S + "\n");
 }
----------------
Log adds a newline for us, right? Why do we want two newlines here?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D47643