[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 4 05:33:59 PDT 2018


sammccall added a comment.

In https://reviews.llvm.org/D47707#1120734, @ilya-biryukov wrote:

> Is there a way to only downrank them if the query does not start with `_`? That would cover the cases when I **do** want the symbols starting with underscore.


This is hard for a few reasons:

- LSP's filter-in-the-editor isn't designed for this kind of case: once the server fails to return a result, it's basically gone
- a remote index now has to know the details of this scoring function (this is true of most things that are querystring-dependent)

This is a problem though. Added a couple of FIXMEs and will ponder a bit.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D47707





More information about the cfe-commits mailing list