[PATCH] D47701: [clangd] Hover should return null when not hovering over anything.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 4 03:32:11 PDT 2018


sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov, klimek.

Also made JSON serialize Optional<T> to simplify this.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D47701

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  clangd/JSONExpr.h
  clangd/XRefs.cpp
  clangd/XRefs.h
  test/clangd/hover.test
  unittests/clangd/JSONExprTests.cpp
  unittests/clangd/XRefsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47701.149701.patch
Type: text/x-patch
Size: 5822 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180604/1e97d55a/attachment.bin>


More information about the cfe-commits mailing list