[PATCH] D47578: Do not enforce absolute path argv0 in windows

Takuto Ikuta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 4 02:37:06 PDT 2018


takuto.ikuta marked 3 inline comments as done.
takuto.ikuta added a comment.

Thank you for review



================
Comment at: llvm/lib/Support/Windows/Process.inc:251
+  // This may change argv0 like below,
+  // * clang -> clang.exe (just add extension)
+  // * CLANG_~1.EXE -> clang++.exe (extend shorname)
----------------
ruiu wrote:
> I believe GetModuleFileName always returns a path with an extension, though it might be 8.3 path.
I meant to say about filename in original argv0 here.


https://reviews.llvm.org/D47578





More information about the cfe-commits mailing list