[PATCH] D47564: [Parse] Use CapturedStmt for @finally on MSVC

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 1 23:41:16 PDT 2018


rjmccall added a comment.

In https://reviews.llvm.org/D47564#1119874, @smeenai wrote:

> In https://reviews.llvm.org/D47564#1118424, @rjmccall wrote:
>
> > No, it was just a general question.  Have you gotten this to a point where it's testable?
>
>
> Yup, it's been working fine in my local testing. There's one more patch that I need to put up, which actually handles doing proper codegen for @try/@catch/@finally; I'm working on cleaning that up right now.


Okay.  And simple tests with throwing exceptions out of the `@finally` block seem to work?

> The other piece of the puzzle is https://reviews.llvm.org/D47233, which emits the proper typeinfo required for this.

Yes, I'll try to get to that, sorry.


Repository:
  rC Clang

https://reviews.llvm.org/D47564





More information about the cfe-commits mailing list