[PATCH] D46971: [DWARF] Get RA from RA register even if it appears unused

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 29 15:54:17 PDT 2018


compnerd added a comment.

It would be nice if we had a test case added for this, but, seems correct to me.



================
Comment at: src/DwarfInstructions.hpp:195
         }
+        else if (i == (int)cieInfo.returnAddressRegister)
+          returnAddress = registers.getRegister(i);
----------------
I think that we should stick to LLVM style (coddled braces) and use C++ style casts.


Repository:
  rUNW libunwind

https://reviews.llvm.org/D46971





More information about the cfe-commits mailing list