[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects
Karl-Johan Karlsson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat May 26 13:08:14 PDT 2018
Ka-Ka added a comment.
In https://reviews.llvm.org/D45686#1113426, @lebedev.ri wrote:
> In https://reviews.llvm.org/D45686#1113425, @Ka-Ka wrote:
> > In https://reviews.llvm.org/D45686#1113414, @aaron.ballman wrote:
> > > In https://reviews.llvm.org/D45686#1109295, @dstenb wrote:
> > >
> > > > Ping.
> > > >
> > > > We have added a lit reproducer for this now in clang-tools-extra: https://reviews.llvm.org/D47251.
> > >
> > >
> > > The above should be rolled into this patch as the test case verifying the behavioral changes.
> > I guess the intention from @dstenb was to submit both patches together. The reason for a separate patch with the testcase alone is that the reproducer use clang-tidy and as far as I know all clang-tidy tests exist in clang-tools-extra.
> .. and both of them exist in the **same** svn repo, or git monorepo. (granted, not many use that)
I see, I didn't know that. Well, then it make sense to merge both patches into a single one. Thanks for clarifying that.
More information about the cfe-commits