[PATCH] D46052: GNUstep Objective-C ABI version 2

David Chisnall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 26 04:19:42 PDT 2018

theraven added inline comments.

Comment at: lib/CodeGen/CGObjCGNU.cpp:512
   /// used to return an untyped selector (with the types field set to NULL).
-  llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+  virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
                            const std::string &TypeEncoding);
xbolva00 wrote:
> This causes 
> CGObjCGNU.cpp:589:16: warning: ‘virtual llvm::Value* {anonymous}::CGObjCGNU::GetSelector(clang::CodeGen::CodeGenFunction&, const clang::ObjCMethodDecl*)’ was hidden [-Woverloaded-virtual]
>    llvm::Value *GetSelector(CodeGenFunction &CGF,
I can't reproduce this, and I'm not sure what the issue is.  The two lines have different overloads, so one shouldn't be hiding the other.

  rC Clang


More information about the cfe-commits mailing list